<html>
<head><meta charset="utf-8"><title>highfive review membership · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html">highfive review membership</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="236686945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/236686945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#236686945">(Apr 29 2021 at 14:56)</a>:</h4>
<p>spawning off of T-compiler meeting discussion of <a href="https://github.com/rust-lang/highfive/issues/278">highfive#278</a></p>



<a name="236688982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/236688982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#236688982">(Apr 29 2021 at 15:03)</a>:</h4>
<p>the discussion <a href="#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202021-04-29.20.2354818/near/236686254">started here</a></p>



<a name="237128748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237128748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237128748">(May 03 2021 at 08:23)</a>:</h4>
<p>Some thoughts and observations: </p>
<ul>
<li>The assignment that highfive makes can only ever be a guess. It has incomplete information and a contributor should always be able to say no to a given assignment.</li>
<li>Being assigned a review that one does not have time or expertise for still incurs a bit of work and mental load, even when one declines the review in the end. It's often unclear how to proceed in that situation.</li>
<li>Highfive knows nothing about PR priorities - but being assigned a PR by the system can sometimes lead to the assumption that "this needs to get done asap". </li>
</ul>
<p>I wonder if there is a good solution to that. highfive does not know how much time a given contributor actually has.</p>



<a name="237129233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237129233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237129233">(May 03 2021 at 08:28)</a>:</h4>
<p>Maybe we can improve things by:</p>
<ul>
<li>distributing the mental overhead of being assigned a PR more fairly - like <span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span>'s PR suggests, and </li>
<li>make it less costly to find another reviewer in case an assignment isn't a good fit - e.g. by making it easy to make highfive roll the dice again and providing a clear, easy to follow, step-by-step procedure for dealing with an assignment (which could even be part of the highfive message)</li>
</ul>



<a name="237129526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237129526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237129526">(May 03 2021 at 08:31)</a>:</h4>
<p>If highfive could take into account the number of currently open, assigned PRs a given candidate already has -- that could also reduce the number of initial "wrong" assignments. And it would give contributors a measure of individual control over how much they are being assigned.</p>



<a name="237155996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237155996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237155996">(May 03 2021 at 12:54)</a>:</h4>
<p>One downside to the number of currently open &amp; assigned PRs is that it's not necessarily the best measure. For example, I usually get to review roughly once every 1-2 weeks, though I try to knock out quick reviews faster, so it's not necessarily true that I shouldn't get assigned a PR even if I have, say, 20 - I'm not overloaded, perse, just high latency.</p>



<a name="237215462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215462">(May 03 2021 at 19:29)</a>:</h4>
<p>Another potential highfive change -- could it wait for a review to be published to assign someone?  It'd be nice if "I posted this as a draft because I know it's not ready to go yet" didn't bother people by default until it was published.</p>
<p>(I guess that's another thing the reroll could help with.  Could <code>r? @ghost</code> when posting it, and re-roll after publishing.)</p>



<a name="237215561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215561">(May 03 2021 at 19:30)</a>:</h4>
<p>maybe highfive should automatically pick <code>@ghost</code> for drafts?</p>



<a name="237215581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215581">(May 03 2021 at 19:30)</a>:</h4>
<p><span class="user-mention" data-user-id="125270">@scottmcm</span> I remember there being a proposal at one point to not assign people for draft PRs, and there was some discussion about the benefits/drawbacks of that.</p>



<a name="237215644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215644">(May 03 2021 at 19:30)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/131828-t-compiler/topic/highfive.20review.20membership/near/237215581">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="125270">scottmcm</span> I remember there being a proposal at one point to not assign people for draft PRs, and there was some discussion about the benefits/drawbacks of that.</p>
</blockquote>
<p>I think that was about whether to run CI, not whether to assign people</p>



<a name="237215674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215674">(May 03 2021 at 19:31)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> I thought both came up, but I could be wrong.</p>



<a name="237215726"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215726" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215726">(May 03 2021 at 19:31)</a>:</h4>
<p>In any case, I think once we have the ability to tell rust-highfive to re-roll, it'll be much more reasonable to not assign someone.</p>



<a name="237215840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237215840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237215840">(May 03 2021 at 19:32)</a>:</h4>
<p><span class="user-mention silent" data-user-id="138448">cuviper</span> <a href="#narrow/stream/131828-t-compiler/topic/highfive.20review.20membership/near/237215561">said</a>:</p>
<blockquote>
<p>maybe highfive should automatically pick <code>@ghost</code> for drafts?</p>
</blockquote>
<p>That might be nicest, actually, since the message in which it does that could also have a message like "And when you're ready, comment <code>r? 🎲</code> to get a reviewer auto-assigned".</p>



<a name="237223090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237223090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237223090">(May 03 2021 at 20:24)</a>:</h4>
<p>Hmm, in my experience draft PRs don't pose any additional problems (moreover, the draft status itself is not useful).<br>
I treat them as regular PRs because in practice PRs from beginners or people unfamiliar with the modified compiler parts often require more (re)work even if they are not marked as drafts.<br>
So if I get a "Draft" PR I make a quick review on the direction and mark it as waiting on author =&gt; problem solved.</p>



<a name="237263323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237263323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237263323">(May 04 2021 at 03:31)</a>:</h4>
<p>Since someone brought up stats in the other thread, I’d love it if we could see aggregate stats about things like review latency and re-assignments so we can begin talking about how to improve those numbers.</p>



<a name="237263462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237263462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237263462">(May 04 2021 at 03:33)</a>:</h4>
<p>A related topic is the waiting-on-author and waiting-on-review labels. People use these to different degrees, which makes their usefulness limited. Should we encourage people to use them more?</p>



<a name="237264087"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237264087" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237264087">(May 04 2021 at 03:45)</a>:</h4>
<p>I can imagine adding commands like <code>@rustbot reviewed</code> and <code>@rustbot revised</code> with permissions scoped to the PR</p>



<a name="237264157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237264157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237264157">(May 04 2021 at 03:46)</a>:</h4>
<p>Though maybe those should go on bors because rustbot is usually for issues</p>



<a name="237304971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237304971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237304971">(May 04 2021 at 11:07)</a>:</h4>
<blockquote>
<p>A related topic is the waiting-on-author and waiting-on-review labels. People use these to different degrees, which makes their usefulness limited. Should we encourage people to use them more?</p>
</blockquote>
<p>Yes!<br>
They are the primary tool for "passing the baton" from author to reviewer and back, and I hope they are used more instead of other ways like "submit a personal plea in PM to get a review".<br>
The review dashboard <a href="https://github.com/pulls/assigned">https://github.com/pulls/assigned</a> shows all the labels and clicking on any <code>S-waiting-on-review</code> label filters the assigned PRs to show only those which currently need a review.</p>



<a name="237313603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237313603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237313603">(May 04 2021 at 12:23)</a>:</h4>
<blockquote>
<p>I can imagine adding commands like <code>@rustbot reviewed</code> and <code>@rustbot revised</code> with permissions scoped to the PR</p>
</blockquote>
<p>You can already do this with <code>@rustbot label: +S-waiting-on-author -S-waiting-on-review</code> and vice versa. I can put that in the dev guide if it makes things easier.</p>



<a name="237345667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237345667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237345667">(May 04 2021 at 15:24)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> I think there's value in making the version of that that the author needs to use shorter, such as <code>@rustbot ready</code>, and mentioning that in various places.</p>



<a name="237345741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237345741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237345741">(May 04 2021 at 15:24)</a>:</h4>
<p><span class="user-mention" data-user-id="239881">@Josh Triplett</span> can you open an issue on triagebot for that? <a href="https://github.com/rust-lang/triagebot/issues/">https://github.com/rust-lang/triagebot/issues/</a></p>



<a name="237346478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237346478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237346478">(May 04 2021 at 15:29)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/issues/1339">https://github.com/rust-lang/triagebot/issues/1339</a></p>



<a name="237349981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237349981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237349981">(May 04 2021 at 15:50)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/issues/1339">https://github.com/rust-lang/triagebot/issues/1339</a></p>



<a name="237349994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/237349994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#237349994">(May 04 2021 at 15:50)</a>:</h4>
<p>thanks!</p>



<a name="244945064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/highfive%20review%20membership/near/244945064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/highfive.20review.20membership.html#244945064">(Jul 05 2021 at 14:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/131828-t-compiler/topic/highfive.20review.20membership/near/237155996">said</a>:</p>
<blockquote>
<p>One downside to the number of currently open &amp; assigned PRs is that it's not necessarily the best measure. For example, I usually get to review roughly once every 1-2 weeks, though I try to knock out quick reviews faster, so it's not necessarily true that I shouldn't get assigned a PR even if I have, say, 20 - I'm not overloaded, perse, just high latency.</p>
</blockquote>
<p>Queue depth could be made adjustable? Or it could look at your approval rate and compare it to the assignment rate and keep the latter close to the former.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>